Skip to content

#pull without args should do the same as git pull without args #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

jcouball
Copy link
Member

@jcouball jcouball commented Mar 1, 2023

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

Fixes #423

Git::Lib#pull with no args currently performs git pull origin master. It sets the remote name to 'origin' and the branch to pull to 'master'. This probably isn't what the user expects and can cause errors or undesired results.

git pull with no args figures out defaults for the remote name and branch name to use. Git::Lib#pull should have the same effect.

…options

Signed-off-by: James Couball <jcouball@yahoo.com>
@jcouball jcouball merged commit b40de70 into master Mar 1, 2023
@jcouball jcouball deleted the default_pull_options branch March 1, 2023 21:22
@jcouball jcouball mentioned this pull request Mar 1, 2023
@jcouball jcouball changed the title #pull with no options should do the same thing as git pull with no options #pull without args should do the same as git pull without args Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull without args results in unexpected operation
1 participant