Skip to content

#checkout without args should do same as git checkout without args #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

jcouball
Copy link
Member

@jcouball jcouball commented Mar 2, 2023

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

Git::Lib#checkout with no args currently performs git checkout master. The branch name default is 'master' even if there is no branch named 'master'. This probably isn't what the user expects and can cause errors or undesired results.

git checkout with no args checks out the current branch which is "a glorified no-op" according to the git-checkout documentation.. Git::Lib#checkout should have the same behavior.

Signed-off-by: James Couball <jcouball@yahoo.com>
@jcouball jcouball merged commit d33d563 into master Mar 2, 2023
@jcouball jcouball deleted the checkout_with_no_options branch March 2, 2023 19:58
@jcouball jcouball changed the title #checkout without args should do same as git checkout with no args #checkout without args should do same as git checkout without args Mar 2, 2023
This was referenced Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant