Skip to content

Add test to ensure that Git.open works for submodules #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2023
Merged

Add test to ensure that Git.open works for submodules #655

merged 1 commit into from
Mar 9, 2023

Conversation

jcouball
Copy link
Member

@jcouball jcouball commented Mar 8, 2023 •
edited
Loading

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

There was no test that ensured that Git.open works for submodules. This PR adds two tests:

  • test that a submodule can be opened from its root directory
  • test that a submodule can be opened from a subdirectory within the submodule

This supersedes #488

@jcouball jcouball force-pushed the test_submodule_open branch 4 times, most recently from 604550d to 3d8bb39 Compare March 9, 2023 15:58
@jcouball
Add test to ensure that Git.open works to open a submodule
40e5acc 
Signed-off-by: James Couball <jcouball@yahoo.com>
@jcouball jcouball force-pushed the test_submodule_open branch from 1c142d4 to 40e5acc Compare March 9, 2023 17:38
@jcouball jcouball merged commit b27a15b into master Mar 9, 2023
@jcouball jcouball mentioned this pull request Mar 9, 2023
Closed
@jcouball jcouball deleted the test_submodule_open branch March 10, 2023 00:26
@jcouball jcouball added the internal-change The PR includes changes that are NOT user facing and will NOT require a release label Mar 10, 2023
@jcouball jcouball mentioned this pull request Mar 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal-change The PR includes changes that are NOT user facing and will NOT require a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcouball