Skip to content

Add support for --update-head-ok to fetch #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dylanrainwater
Copy link
Contributor

@dylanrainwater dylanrainwater commented Mar 17, 2023

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

Hey! Thanks for maintaining this awesome gem. This is my 1st PR here, it's to add support for the --update-head-ok (or -u) option to '#fetch`. Looking forward to (hopefully) getting this shipped! 🚢

@dylanrainwater dylanrainwater force-pushed the dylan/support-git-fetch---update-head-ok branch 2 times, most recently from aae56b1 to 2913c73 Compare March 17, 2023 21:04
Signed-off-by: Dylan Rainwater <dylancrainwater@gmail.com>
Signed-off-by: Dylan Rainwater <dylan@splitwise.com>
@dylanrainwater dylanrainwater force-pushed the dylan/support-git-fetch---update-head-ok branch from 2913c73 to 51fdf24 Compare March 17, 2023 21:04
@dylanrainwater
Copy link
Contributor Author

The docs say I need to request a reviewer, but I don't think I have the permissions to do so here. cc @jcouball

Copy link
Member

@jcouball jcouball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @dylanrainwater! The code looks great.

@jcouball jcouball merged commit 3c704ef into ruby-git:master Mar 19, 2023
@jcouball jcouball mentioned this pull request Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants