Do not change global env #675
Conversation
Instead pass relevant environment to the actual shell command being run Signed-off-by: James Couball <jcouball@yahoo.com>
106d8e8 to
4a969a0
Compare
Signed-off-by: James Couball <jcouball@yahoo.com>
d029e4c to
3e12987
Compare
Signed-off-by: James Couball <jcouball@yahoo.com>
3e12987 to
d684854
Compare
|
Some version of this would be nice to have: the current global env version in practice means only one git operation can run at a time per process, which is rather inconvenient. Unless I'm missing something, based on what was merged in #673 I think this can be changed to just have "option 2" (capture2/popen2) and is then probably in a good state? |
|
All methods I have tried did not work for one reason or another in JRuby on Windows. I have released git-2.0.0-pre1 which I believe will address this issue in a different way. You can see PR #684 for details. This version still does not support JRuby for Windows, but I believe there is a path to victory there. The API of this gem is unchanged. All the changes are below the hood. |
|
Fixed in #684 and released in 2.0.0. |
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
Do not change ENV variables of a current process. Instead pass relevant environment to the actual shell command being run.
this PR is built on top of #673