When core.ignorecase, check Status for files case-insensitively #724
Conversation
Fixed ruby-git#586. Include a note about the inconsistent behavior when ignoreCase is not set to match the case-sensitivity of the file-system itself.
f66c543 to
fd6bc67
Compare
I actually initially had it memoized, and had started down the path of memoizing all the other methods, but it was making the PR quite large. The existing predicates actually are far worse already, as they generate the corresponding collection dynamically in each call by iterating the I decided that meant that the working set of items must typically be small enough not to worry about it, but I'd be happy to roll up a PR memoizing all the things, if that's of interest? |
|
I am interested but can live without it for now. Let's see if anyone complains. |
Fixes #586 by making
Status#changed?case-insensitive whencore.ignoreCaseis set. Also solve the matching unreported issues forStatus#added,Status#deleted, andStatus#untracked.I did run into a bit of an issue trying to write thorough tests for these, because it turns out that git itself doesn't support setting
core.ignoreCaseto a value that doesn't match the behavior of the file-system; that option is provided so you can tell git how the file-system is going to act, not so you can control git's behavior! In the tests here, I do break that guideline, but because I don't actually rename any files,gitdoesn't have trouble - just don't try to make it test the case that was actually reported, because that will not work.