Skip to content

Improved error message of rev_parse #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Improved error message of rev_parse #789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/git/lib.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ def full_log_commits(opts = {})
def rev_parse(revision)
assert_args_are_not_options('rev', revision)

command('rev-parse', revision)
command('rev-parse', '--revs-only', '--end-of-options', revision, '--')
end

# For backwards compatibility with the old method name
Expand Down
2 changes: 1 addition & 1 deletion tests/units/test_lib.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ def test_rev_parse_with_bad_revision
end

def test_rev_parse_with_unknown_revision
assert_raise(Git::FailedError) do
assert_raise_with_message(Git::FailedError, /exit 128, stderr: "fatal: bad revision 'NOTFOUND'"/) do
@lib.rev_parse('NOTFOUND')
end
end
Expand Down
Loading