Don't trigger our own deprecation warning #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23cf586 to
087c5fa
Compare
(bin/test prepends the unit_test directory; the quoted calls previously would fail because it ended up trying to run `tests/units/test/units/test_archive.rb`)
Use the keyword parameter, not the positional one.
087c5fa to
2aae0d4
Compare
|
@nevinera thanks! I was meaning to do this myself. Let me review what you have tomorrow (I am in West Coast US) and I'll merge if things look good. |
jcouball
approved these changes
Jul 8, 2025
|
I put this in the test_help.rb as I was doing all the Rubocop integration (which triggered a lot of the deprecations): # Silence deprecation warnings during tests
Git::Deprecation.behavior = :silenceMy next change is to remove this and deal with all the deprecation warnings that the tests produce (there is a lot). A lot of these are tests that need to be updated but I bet some are are (as you characterize) caused by calling our own deprecated stuff. Thanks for reminding me that this needs to be done. |
|
Sure, let me know if I can help with that :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was getting a lot of deprecation warnings from inside this gem, but when I tracked them down, they were actually just an internal call, and also deprecated internally. Easy fix :-)
Git.open(".")can reproduce the issue on 4.0.1:Git.opencallsGit::Base.openinitialize_components(line 157)Git::Index.newwith a second positional parameterGit::Indexis a straight subclass ofGit::Path, which warns us about the positional parameterI started to open an issue, and then decided that was silly - this is a trivial fix. (Though I guess I'll need to wait for a gem release to escape the cli noise)
While exercising it, I also noticed that the comments in Rakefile describing how to run individual tests (
bin/test tests/units/test_archive.rb) were also outdated, and corrected them.