Handle commits with newlines in the message. #83
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
process_commit_data was toggling between message and header parsing for every bare newline encountered in the data, which led to the elision of every other paragraph in a commit message. Now the switch to message parsing is permanent; once the headers have been found we don't need to look for them any more.
|
@benstiglitz Sadly there is a lot of information after the message 😔 It's not just a header followed by a message. It's obviously still an issue but we have to figure out the correct way to parse it. |
|
Looking at commit.c in the git repo it seems that there will never be any headers after the subject and message. |
|
I have tried it myself. Somehow it's reaching with a lot of information. Just run the tests using the change and you will see how it fails. I'll try to inspect the internals and fine a solution to this but turning |
|
Fixed for single commits Still working on |
|
Working over |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process_commit_data was toggling between message and header parsing for every bare newline encountered in the data, which led to the elision of every other paragraph in a commit message. Now the switch to message parsing is permanent; once the headers have been found we don't need to look for them any more.