Fix deprecations and improve warning reporting #830
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore previously deprecated Git::Diff methods and ensure accurate deprecation warnings point to user code.
Update tests to eliminate the use deprecated features (unless testing deprecations themselves).
Make tests that emit a deprecation warning fail to enforce clean test output.
Adjust the deprecation horizon for clarity on future removals.
This partially addreses #829. The only thing left is to test that deprecation warnings are issued in the right circumstances.