This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@peterkovacs Sorry for the lack of feedback on this one. Do you have a chance to rebase it on top of the latest master version?

@perlun No problem. I've rebased and gotten the tests passing.

Apologies, it looks like this PR has been sitting for a while. If you want to get it merged, please fix the merge conflicts. I took a look at them and it wasn’t obvious how to fix.

Hi @jcouball, no worries. I have rebased the PR onto the latest master. Let me know if there's anything else you need.

@peterkovacs sorry to have to come back to you one more time but your commit was missing the DCO sign-off so I merged a few other PRs ahead of this one.

Since I have made several merge commits that I don't want in the commit history, I think you should (1) roll your branch back to your Nov 22nd commit 8382b2b, (2) rebase that with the current master, (3) include the DCO sign-off with the resulting commit, and (4) force push the result.

If there is a better/easier way to clean up the commits, I am open to suggestions.

If you can do this in the next day or so, I'll hold off on any other changes to master so you won't be asked to rebase again.

@peterkovacs Sorry again for the bother. I'd love to land this PR for the next release but need your DCO sign off.

@jcouball I think i've done what you're looking for, please let me know if I screwed something up. Thank you!