Skip to content

Inconsistent validation messages #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dgasper opened this issue Oct 11, 2016 · 3 comments
Closed

Inconsistent validation messages #1508

dgasper opened this issue Oct 11, 2016 · 3 comments
Labels

Comments

@dgasper
Copy link
Contributor

dgasper commented Oct 11, 2016

When defining parameters in separate requires, the validation errors include errors for all defined params. For example the following returns one is missing, two is missing

params do
  requires :one, type: Integer
  requires :two, type: Integer
end

In contrast, the following usage of a single requires for multiple params only returns one is missing.

params do
  requires :one, :two, type: Integer
end

I've tracked down where the validation is stopped to this line. Removing it results in both above examples returning one is missing, two is missing.

Is this something we would want or is the above behavior expected?

@dblock
Copy link
Member

dblock commented Oct 11, 2016

This looks like a bug. The two should be equivalent IMO.

@towanda
Copy link
Contributor

towanda commented Oct 31, 2016

@dblock Could you please close this? It's fixed by #1510

@dblock
Copy link
Member

dblock commented Nov 1, 2016

Closed via #1510.

@dblock dblock closed this as completed Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants