remove multi_json dependency #1292
Conversation
| * `:xml`: use object's `to_xml` when available, usually via `MultiXml`, otherwise call `to_s` | ||
| * `:txt`: use object's `to_txt` when available, otherwise `to_s` | ||
| * `:serializable_hash`: use object's `serializable_hash` when available, otherwise fallback to `:json` | ||
| * `:binary`: data will be returned "as is" | ||
|
|
||
| Grape now not longer use MultiJson as JSON processor.If you want to continue to use MultiJson, you can use it by below |
There was a problem hiding this comment.
This should be moved to UPGRADING. Some minor "better" English: "Grape no longer uses MultiJson as default JSON processor. To use MultiJson add multi_json to your Gemfile and set config.json_processor.
There was a problem hiding this comment.
README should contain an explanation of how to switch JSON processors though.
|
First, thanks for keeping at it. It's an important and sensitive change given that it will affect everybody. I don't like the global configuration, that prevents you from shipping two versions of the API where old uses multi_json and new uses json, basically we don't provide a path for deprecating an old JSON processor, we force you to remove it. I think what we want is a per-api configuration, like I am not against another global option, but I don't think it should be Grape global, maybe just formatter global, like What do you think? |
|
Bump @u2 I think this would still be awesome. |
|
Replacing in favor of #1623. |
#1274