Fix logic for include_parent_namespaces option
#1415
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| all_declared_params = route_setting(:declared_params) | ||
| current_namespace_declared_params = route_setting(:saved_declared_params).last | ||
|
|
||
| declared_params ||= options[:include_parent_namespaces] ? all_declared_params : current_namespace_declared_params |
There was a problem hiding this comment.
I think it won't harm to provide a short explanation what is going on here.
route_setting(:declared_params) keep every parameter in a flat array, for example:
route_setting(:declared_params) # [:parent_name, :child_name, :child_age, :grandchild_name]
However, route_setting(:saved_declared_params) stores parameters in groups by namespace.
route_setting(:saved_declared_params) # [[:parent_name], [:child_name, :child_age], [:grandchild_name]]
The last element here contains only parameters that were defined in current namespace.
|
I like this. This just needs a CHANGELOG entry, please. |
| @@ -15,6 +15,7 @@ | |||
| * [#1365](https://github.com/ruby-grape/grape/pull/1365): Fix finding exception handler in error middleware - [@ktimothy](https://github.com/ktimothy). | |||
| * [#1380](https://github.com/ruby-grape/grape/pull/1380): Fix `allow_blank: false` for `Time` attributes with valid values causes `NoMethodError` - [@ipkes](https://github.com/ipkes). | |||
| * [#1384](https://github.com/ruby-grape/grape/pull/1384): Fix parameter validation with an empty optional nested `Array` - [@ipkes](https://github.com/ipkes). | |||
| * [#1415](https://github.com/ruby-grape/grape/pull/1415): Fix logic for `include_parent_namespaces` option - [@304](https://github.com/304). | |||
There was a problem hiding this comment.
It doesn't say where, it's in declared, maybe say "Fix declared(params, include_parent_namespaces: true)"?
Fixed the tests to point that out.
Based on PR ruby-grape#1408. * Add specs to test different combinations of namespaces * Add documentation for the `include_parent_namespaces` option
8a7a24c to
497c30d
Compare
|
Merged via 7d1b3e3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #1408.
include_parent_namespacesoption