-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Use Active support functions #2326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Active support functions #2326
Conversation
…pport functions Use each_with_object instead of each/inject etc ...
Use deep_dup instead of dup for rack_params
Replace unless present? by if blank?
🤞 that the ActiveSupport versions perform as well |
Should we add a minimum version for active support ? Since we're testing rails 5.2 to 7.0, tests are covering ActiveSupport 5 to 7. Thus, it doesn't test < 5.2. At least we know it works from 5 and beyond :) |
I've restrict to ActiveSupport >= 5. It doesn't work below because of this and we're talking of Ruby 1.9 |
LGTM want to finish this PR? |
I'll run a quick test suites on our codebase to see if there's anything wrong. |
Everything looks good. There's only the danger part that is failing. |
Not sure what the Danger problem is, but there's an extra |
I think we should either release 1.7.1 before merging this, or make this 1.8.0, wdyt? |
Good idea, after this PR, I'll open a another that will use |
All yours to release/bump! |
Done. I hope everything is ok. I'm not releasing that often. |
Let's increment version to 1.8.0 as part of this PR? Feel free to merge after. |
This PR replace some custom made functions in favour of ActiveSupport's equivalent.
deep_symbolize_keys
anddeep_merge!
object.present? ? object : nil
bypresence
!include?
byexclude?
dup
andduplicable?
instead ofduplicatable?
andduplicate