Implement nested with support in parameter DSL
#2434
Conversation
| def new_scope(args, _, &block) | ||
| nested_scope = self.class.new | ||
| nested_scope.new_group_scope(args, &block) | ||
| nested_scope | ||
| end |
There was a problem hiding this comment.
Not sure about this, but looks legit for me.
|
Looks good. Document it in README please? Maybe add a test with 3 levels just to be sure ;) |
| @@ -264,6 +264,7 @@ def new_scope(attrs, optional = false, &block) | |||
| parent: self, | |||
| optional: optional, | |||
| type: type || Array, | |||
| group: @group, | |||
There was a problem hiding this comment.
@dblock I've added more specs and found that in case of mix of nested scopes and groups, with doesn't work as expected (if there is anything expected). The reason is that when a new parameter with a block is defined , a new scope is created without any link to the current group.
There was a problem hiding this comment.
Open an issue with a failed spec?
There was a problem hiding this comment.
Whether it is an issue or an undocumented feature is always hard to tell in such mature projects :)
There was a problem hiding this comment.
I follow the rule of thumb of 1) is there a spec (undocumented feature), 2) is it in README (documented feature).
| prev_group = @group | ||
| @group = args.clone.first | ||
| yield | ||
| @group = prev_group |
There was a problem hiding this comment.
Since we do not really create scopes, this is my imitation of it.
b86686c to
6bc75fc
Compare
Motivation
Previously, the
with' method in the Parameter DSL did not support nested structures. This forced to redefine the entire attribute set for each nested scope, which was cumbersome and prone to errors, especially in complex parameter structures.Solution
This PR introduces enhanced functionality to the
withmethod that allows nested scopes to inherit and extend the attributes defined in parent scopes. By merging attributes from the current group with the new attributes, it simplifies parameter declarations and ensures a clean, DRY approach to specifying shared attributes in nested parameter contexts.