Deprecates Grape's Extensions for ParamsBuilder in favor of build_with #2540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds params_builder.rb registration process Update README.md Update UPGRADING.md Add exceptions query_parsing.rb and unknown_params_builder.rb
dblock
approved these changes
Feb 27, 2025
No, anyone can define their own. I've just reused the same technique as parsers, error_formatters, etc ... |
dblock
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
params_builderby using the same technique asvalidators,parsers,error formatters... etc which is registration with a symbolized short name. IMO, it makes sense to follow the same pattern like other components that we have and theregistrationpart ease the customization.There are 3 ways to configure the
params_builder:Grape.config.params_builderbuild_withinsideparamsscopeThis PR is an hybrid meaning it does not remove the old way, its just deprecating it. Here are the deprecations:
build_withorGrape.config.param_builderGrape::Extensions::Hashie::Mash::ParamBuilderSee UPGRADING.md
This PR also adds
build_witha the API level since including the extensions concerns are deprecated.