Rack expectations test #563
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. We'll lock up with a newer version of Rack when that's available. |
|
@zuk You will have to pickup a newer version of Rack from HEAD, there hasn't been a release in a long time. |
|
1.6.0.beta of rack is out. This issue is solved with this version. |
|
Grape doesn't lock to a particular Rack version, so now that Rack 1.6.0 has shipped, this works. I committed the test with some minor changes with c72181d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the description #559, this test demonstrates a bug in
rack 1.5.2wherebyparamsis not correctly populated whenrack.inputis aTempfilerack.inputis aTempfilein various circumstances. In our case it was with apumawebserver frontend serving requests with a large bodyThis test is designed to fail against
rack 1.5.2- but works againstrack#master(8dc31fec37at the time of writing)