Fix: allow usage of attributes with name 'key' if Hash objects are used
#111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee7ee3e to
a63875f
Compare
| @@ -557,7 +557,7 @@ def delegate_attribute(attribute) | |||
| if respond_to?(name, true) | |||
| send(name) | |||
| else | |||
There was a problem hiding this comment.
While you're here, I think this can be collapsed into an elsif.
a63875f to
ee3b6cb
Compare
| @@ -557,7 +557,7 @@ def delegate_attribute(attribute) | |||
| if respond_to?(name, true) | |||
| send(name) | |||
| else | |||
| if object.respond_to?(name, true) | |||
| if object.respond_to?(name, true) && object.method(name).arity == 0 | |||
There was a problem hiding this comment.
This worries me. If there's a special case with Hash I would just check for that.
|
Alright, I'll update the pull request in a few minutes... |
ee3b6cb to
e1815d7
Compare
|
Pull is updated, arity check was replaced with |
|
Much better. Merging. |
dblock
added a commit
that referenced
this pull request
Mar 10, 2015
Fix: allow usage of attributes with name 'key' if `Hash` objects are used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix now is checking the method arity in the
delegate_attributemethod. With this change the key attribute will be fetched and instead of thekeymethod (with arity 1) being invoked.The fix includes a
specthat demonstrates the issue and fails without the changes.