Refactoring: extract delegating logic. #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1fb3628 to
971d7c4
Compare
This one solves many problems at once: - Fixes ruby-grape#140. For this one I changed specs a bit. It's breaking but I think it's worth it. - Fixes ruby-grape#142 differently because now `respond_to?(name, true)` stuff is incapsulated in `Delegator::PlainObject`. - Old `delegate_attribute` catched `NoMethodError` and re-raised it with custom message. It's incorrect because `NoMethodError` can occur deep inside in method call — this exception simply doesn't mean that attribute doesn't exist. - Solves the problem that object is checked to `is_a?(Hash)` and `respond_to?(:fetch, true)` multiple times. - Extracts delegating logic to separate delegator classes. - Removes constructing of `valid_exposures` at all — there's no need in this method now.
|
I like this, merging as is. |
dblock
added a commit
that referenced
this pull request
Jul 20, 2015
Refactoring: extract delegating logic.
marshall-lee
added a commit
to marshall-lee/grape-entity
that referenced
this pull request
Aug 3, 2015
This one fixes a regression introduced in ruby-grape#147: entity instance methods were exposed with `NoMethodError`. Fixes ruby-grape#163. Additional specs are added.
marshall-lee
added a commit
to marshall-lee/grape-entity
that referenced
this pull request
Aug 3, 2015
This one fixes a regression introduced in ruby-grape#147: entity instance methods were exposed with `NoMethodError`. Fixes ruby-grape#163. Additional specs are added.
marshall-lee
added a commit
to marshall-lee/grape-entity
that referenced
this pull request
Aug 3, 2015
This one fixes a regression introduced in ruby-grape#147: entity instance methods were exposed with `NoMethodError`. Fixes ruby-grape#163. Additional specs are added.
marshall-lee
added a commit
to marshall-lee/grape-entity
that referenced
this pull request
Aug 3, 2015
This one fixes a regression introduced in ruby-grape#147: entity instance methods were exposed with `NoMethodError`. Fixes ruby-grape#163. Additional specs are added.
marshall-lee
added a commit
to marshall-lee/grape-entity
that referenced
this pull request
Aug 10, 2015
This one fixes a regression introduced in ruby-grape#147: entity instance methods were exposed with `NoMethodError`. Fixes ruby-grape#163. Additional specs are added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one solves many problems at once:
respond_to?(name, true)stuff is incapsulated inDelegator::PlainObject.delegate_attributecatchedNoMethodErrorand re-raised it with custom message. It's incorrect becauseNoMethodErrorcan occur deep inside in method call — this exception simply doesn't mean that attribute doesn't exist.is_a?(Hash)andrespond_to?(:fetch, true)multiple times.valid_exposuresat all — there's no need in this method now.