Fix: return self instead of nil if no attribute was deleted
#203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense. This changes the interface, I think we need an UPGRADING ala https://github.com/ruby-grape/grape/blob/master/UPGRADING.md, could you make one please? Bump version to 0.6.0 as well. |
|
done, what u think @dblock ? |
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| * Your contribution here. | |||
| * [#202](https://github.com/ruby-grape/grape-entity/pull/202): Fix: Reset `@using_class` memoization on `.setup` - [@rngtng](https://github.com/rngtng). | |||
| * [#203](https://github.com/ruby-grape/grape-entity/pull/203): Fix: return `self` instead of `nil` if no attribute was deleted - [@rngtng](https://github.com/rngtng). | |||
There was a problem hiding this comment.
This seems incorrect, shouldn't it say "Grape::Entity::Exposure::NestingExposure::NestedExposures.delete_if always returns exposures."? It's unlcear what self is and what the story here is ;)
dblock
added a commit
that referenced
this pull request
Jan 28, 2016
Fix: return `self` instead of `nil` if no attribute was deleted
|
Merged, thanks. |
|
np, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a given attribute of
delete_ifcouldn't be found,nilwas returned as described in ruby spec. Although, I expected@exposuresto be return, to maintain consistency with the cases when sth. is found.