-
Notifications
You must be signed in to change notification settings - Fork 152
fix-serializable-hash-option #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-serializable-hash-option #219
Conversation
I am not sure what this does, it needs specs and a CHANGELOG entry please? |
Options already pass to output result in Also all others else branch, didn't pass options to serializable_hash. May be it's old code. I will add CHANGLOG entry. |
Ok makes sense. You need to write a test that shows a failure without this fix, please. |
commit test and change log |
let(:fresh_class) { Class.new(Grape::Entity) } | ||
|
||
it 'Test' do | ||
class Address < Grape::Entity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are global scope. Can you declare them with let(:address) { Class.new(...) }
please?
Thanks. See my comments on tests. Squash your commits too please if you can. |
Merged. |
No description provided.