Fix for #215. Allow delegate_attribute for derived classes #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 28, 2016 17:03
another way to check derived entity group delegate_attribute tests
| @@ -4,6 +4,7 @@ | |||
| * [#215](https://github.com/ruby-grape/grape-entity/pull/217): Fix: `#delegate_attribute` no longer delegates to methods included with `Kernel` - [@maltoe](https://github.com/maltoe). | |||
| * [#219](https://github.com/ruby-grape/grape-entity/pull/219): Fix: double pass options in serializable_hash - [@sbatykov](https://github.com/sbatykov). | |||
| * [#226](https://github.com/ruby-grape/grape-entity/pull/226): Add fetch method to fetch from opts_hash - [@alanjcfs](https://github.com/alanjcfs). | |||
| * [#231](https://github.com/ruby-grape/grape-entity/pull/231): Fix for #215 allow delegate_attribute for derived enyity - [@sbatykov](https://github.com/sbatykov) | |||
There was a problem hiding this comment.
If you're going to mention #215, link it the same way as the PR, but generally we just don't.
Entity is misspelled.
There needs to be a period at the end of this, see other lines;)
|
This is great, just amend the text changes and I'll merge. Don't hesitate to squash the commits too. Thanks. |
|
It would be great to handle the delegation properly in the next version. Do you @sbatykov have the intention to finalize this? |
|
What is the status of this one, we are forced to do some ugly stuff to handle the degraded inheritance support #217 introduced. |
|
@dblock, works like a charm. Thanks for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.