Skip to content

Provide Grape::Entity::Options#dig #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 1, 2017
Merged

Provide Grape::Entity::Options#dig #277

merged 8 commits into from
Nov 1, 2017

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Oct 31, 2017

No description provided.

@coveralls
Copy link

coveralls commented Oct 31, 2017

Coverage Status

Coverage increased (+0.02%) to 92.74% when pulling e939737 on kachick:options-dig into 6a384cd on ruby-grape:master.

@ruby-grape ruby-grape deleted a comment from coveralls Oct 31, 2017
@ruby-grape ruby-grape deleted a comment from coveralls Oct 31, 2017
@LeFnord
Copy link
Member

LeFnord commented Oct 31, 2017

thanks @kachick … will mörge it after #278

@kachick
Copy link
Contributor Author

kachick commented Nov 1, 2017

Ah... ruby provide Hash#dig since 2.3... So can I quote the rspecs in 2.2.x ?

- rvm: 2.2.7

it does not mean regression.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.74% when pulling ad24d35 on kachick:options-dig into 030d02e on ruby-grape:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.74% when pulling ad24d35 on kachick:options-dig into 030d02e on ruby-grape:master.

@coveralls
Copy link

coveralls commented Nov 1, 2017

Coverage Status

Coverage increased (+0.02%) to 92.74% when pulling ad24d35 on kachick:options-dig into 030d02e on ruby-grape:master.

@coveralls
Copy link

coveralls commented Nov 1, 2017

Coverage Status

Coverage increased (+0.02%) to 92.74% when pulling 036f297 on kachick:options-dig into 030d02e on ruby-grape:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.74% when pulling 929b966 on kachick:options-dig into 030d02e on ruby-grape:master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 1, 2017

Coverage Status

Coverage increased (+0.02%) to 92.74% when pulling 929b966 on kachick:options-dig into 030d02e on ruby-grape:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.74% when pulling 986d978 on kachick:options-dig into 030d02e on ruby-grape:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.74% when pulling 986d978 on kachick:options-dig into 030d02e on ruby-grape:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.74% when pulling 986d978 on kachick:options-dig into 030d02e on ruby-grape:master.

@coveralls
Copy link

coveralls commented Nov 1, 2017

Coverage Status

Coverage increased (+0.02%) to 92.74% when pulling 986d978 on kachick:options-dig into 030d02e on ruby-grape:master.

@LeFnord LeFnord merged commit 0a81a4d into ruby-grape:master Nov 1, 2017
@kachick
Copy link
Contributor Author

kachick commented Nov 1, 2017

Thank you! 🙇

@kachick kachick deleted the options-dig branch November 1, 2017 21:34
@yuya-takeyama
Copy link

@LeFnord
Hi, is there any plan to release this change as a new version?

@LeFnord
Copy link
Member

LeFnord commented Dec 19, 2017

yeap, there is a plan … will do it after the new ruby is out → in the next days :)

@kechol
Copy link

kechol commented Jan 24, 2018

Hi @LeFnord !
It's been a while after Ruby v2.5.0 has been released. Do you have any plan to release a new version of grape-entity? I saw you've already worked for ruby 2.5 at #287 , but if you have any other concerns or obstacles, I'd grad to hear that. Thanks!

@LeFnord
Copy link
Member

LeFnord commented Jan 25, 2018

release 0.7.0 is out … thanks again 😄

@yuya-takeyama
Copy link

Thank you @LeFnord, now I'm trying to update the gem in our products.
I really appreciate your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants