Look for method on entity before calling on object #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,7 +5,7 @@ Next Release | |||
| * [#18](https://github.com/intridea/grape-entity/pull/18): Add `safe` option to `expose`, will not raise error for a missing attribute - [@fixme](https://github.com/fixme). | |||
| * [#16](https://github.com/intridea/grape-entity/pull/16): Add `using` option to `expose SYMBOL BLOCK` - [@fahchen](https://github.com/fahchen). | |||
| * [#24](https://github.com/intridea/grape-entity/pull/24): Return documentation with `as` param considered - [@drakula2k](https://github.com/drakula2k). | |||
| * Your contribution here. | |||
|
There's a merge conflict, please merge from upstream. I'd also appreciate if you could please squash these commits into one. |
|
Whoops. My bad! Fixed the changelog, squashed into 1 commit, rebased from usptream/master and force pushed to my feature branch. Hopefully that was the correct process. Please let me know if there's any further issues that come up. |
|
Love it, lets merge. |
dblock
added a commit
that referenced
this pull request
Oct 15, 2013
Look for method on entity before calling on object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying to instance eval the block in a way that operates at the instance, it seemed much cleaner and more like idiomatic OOP to have exposures try methods on the instance before trying them on the wrapped object. This is a pattern you'll find in Roar as well.
Resolves #28