Loosens ActiveSupport to 3 #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
LeFnord
reviewed
Mar 28, 2018
| require 'active_support/version' | ||
| require 'active_support/core_ext/hash' if ActiveSupport::VERSION && | ||
| ActiveSupport::VERSION::MAJOR && | ||
| ActiveSupport::VERSION::MAJOR < 4 |
There was a problem hiding this comment.
is ActiveSupport.version.to_s < '4' the same?
There was a problem hiding this comment.
ActiveSupport 3 has a different API for version (https://github.com/rails/rails/blob/3-2-stable/activesupport/lib/active_support/version.rb). It's closer to 'activesupport/gem_version' in 4+.
LeFnord
reviewed
Mar 28, 2018
grape-entity.gemspec
Outdated
| @@ -18,8 +18,7 @@ Gem::Specification.new do |s| | |||
|
|
|||
| s.rubyforge_project = 'grape-entity' | |||
|
|
|||
| s.add_runtime_dependency 'activesupport', '>=4.0' | |||
| # FIXME: remove dependecy | |||
| s.add_runtime_dependency 'activesupport', '>= 3.0.0' | |||
There was a problem hiding this comment.
please can you change the lines, FIXME should be above multi_json, thanks
|
thanks @EricSchultz … will rebase and mörge it, after this one #301, ok |
Here's an example of a CHANGELOG.md entry: * [#300](https://github.com/ruby-grape/grape-entity/pull/300): Loosens activesupport to 3 - [@ericschultz](https://github.com/ericschultz).Generated by 🚫 danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #289 and a second attempt (original pull request at #290)
The spec_helper now loads the needed hash extensions for ActiveSupport < 4. In ActiveSupport >=4, there's no change other than the ActiveSupport version info being loaded, which has no effect test functioning.