Allow exposures to call methods defined in included modules #307

robertoz-01 · 2018-09-04T09:24:57Z

Fix Exposure doesn't call method that was included through a module #258

It makes possible for the exposure to use methods defined in modules included in the entity. eg:

module MyModule
  def a_value
    ...
  end
end

class A < Grape::Entity
  include MyModule
  expose :a_value
end

* Fix ruby-grape#258

grape-bot · 2018-09-04T09:25:53Z

	1 Error
🚫	One of the lines below found in CHANGELOG.md doesn’t match the expected format. Please make it look like the other lines, pay attention to periods and spaces.

* [#258](https://github.com/ruby-grape/grape-entity/pull/307): Allow exposures to call methods defined in modules included in an entity [@robertoz-01](https://github.com/robertoz-01).

Generated by 🚫 danger

coveralls · 2018-09-04T09:26:56Z

Coverage increased (+0.02%) to 96.11% when pulling 3e00c1b on robertoz-01:handle-module-included-in-entity into 55383e5 on ruby-grape:master.

LeFnord · 2019-01-29T15:15:04Z

thanks @robertoz-01 … and sorry for the late reply … think this is a welcome feature :)

Allow exposures to call methods defined in included modules

78c1e3b

* Fix ruby-grape#258

robertoz-01 and others added 2 commits September 4, 2018 11:29

Update Changelog with the Pull Request link

4d13daa

Merge branch 'master' into handle-module-included-in-entity

3e00c1b

LeFnord merged commit 52a2851 into ruby-grape:master Jan 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow exposures to call methods defined in included modules #307

Allow exposures to call methods defined in included modules #307

robertoz-01 commented Sep 4, 2018 •

edited

Loading

grape-bot commented Sep 4, 2018 •

edited

Loading

coveralls commented Sep 4, 2018 •

edited

Loading

LeFnord commented Jan 29, 2019

Allow exposures to call methods defined in included modules #307

Allow exposures to call methods defined in included modules #307

Conversation

robertoz-01 commented Sep 4, 2018 • edited Loading

grape-bot commented Sep 4, 2018 • edited Loading

coveralls commented Sep 4, 2018 • edited Loading

LeFnord commented Jan 29, 2019

robertoz-01 commented Sep 4, 2018 •

edited

Loading

grape-bot commented Sep 4, 2018 •

edited

Loading

coveralls commented Sep 4, 2018 •

edited

Loading