🔥 Remove FetchableObject
#369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry @danielvdao … for the latency, shame on me please can an CHANGELOG and UPGRADE entry thanks |
|
Thanks, I'll take care of it 🔥 |
|
@LeFnord done! Let me know if this is what you were looking for. |
|
Hey @LeFnord some of the Rubocop violations are going off, but I don't think they're related to my PR. What do you think? 🤔 |
|
mmh, will have an eye on |
danielvdao
commented
Feb 16, 2023
|
I'm on it |
|
thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A PR addressing this issue: #368
The thing I am confused about is why we check if
object.respond_to?(:fetch, true). Implementing#fetchis tricky and I think that most of the time (if not always) we should rely onHashto implement#fetchas that's in Ruby stdlib. Otherwise just default to#public_send.Happy to close if it doesn't make sense either - but wanted to give it a shot and it looks like all tests still pass.
cc @LeFnord