I haven't tried it, but maybe we need a proper presenter for the Hash type in grape-entity. I mean, what's different between a real model class and a Hash anyway?

I haven't tried it, but maybe we need a proper presenter for the Hash type in grape-entity.

👍

But, it will be a breaking change (regarding to the specs).

Also what need's a change in my point of view is the representation of Collections.
I want to be able to use my collection as items in my presenter. Example:

  present  collection_items,
                with: Entities::Collection

With this example every item will be wrapped in an Entities::Collection and there
is no easy way to wrap the hole collection in an Entities::Collection and present every
item in this collection in an Entities::Item

I think the entity should have a flag or option to show that it can handle a collection
and don't wrapp every item.

Did you have a look at https://github.com/objects-on-rails/display-case? I like it's abroach to
check if the real object should be decorated with the presenter.

We can make breaking changes as long as they are meaningfully better.

Personally the display-case indirection is one level too pure for me :)

Personally the display-case indirection is one level too pure for me :)

Can you please explain what you are missing? I don't want to head into the wrong direction.

I was just commenting on display-case. That's really beyond the scope of this workitem.

@dblock I did refactore my proposal maybe it will fit.

I really like the implementation and I also do like present_collection very much. Could you please update README, add to the CHANGELOG and squash the commits? I'll merge. Thx.

Should present_collection be represent_collection as it's parallel to represent?

present_collection is much a like root it only says, hey this Entity is used for presenting a collection, don't do any magic with object to present. So it isn't the same like represent. Another approach would be to create a subclass of Entity like CollectionEntity and override represent. But I have no clue how to make it simply work with include Grape::Entity::DSL in a nother class.

PS: With a subclass you have to fix

base.const_set(:Entity, Class.new(ancestor_entity_class || Grape::Entity)) unless const_defined?(:Entity)

in the DSL module some how to allow Entity be a kind of CollectionEntity

I figured it out re: present_collection, deleted my comment but not fast enough :)

Ah, ok. Different timezone's have there drawback's, so I have to be fast ;)

@dblock changed & squashed

Merged via b54bf68. Thank you.