Skip to content

Respect nested conditions #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2014
Merged

Respect nested conditions #98

merged 1 commit into from
Nov 14, 2014

Conversation

zbelzer
Copy link
Contributor

@zbelzer zbelzer commented Nov 13, 2014

I was surprised this didn't work, but seeing that it was just a hash, I kind of get why not. Seemed simple enough to add this behavior as the nested exposures carry this info around.

$ rake
Running RuboCop...
Inspecting 9 files
.........

9 files inspected, no offenses detected
.....................................................................................................

Finished in 0.02879 seconds (files took 0.82928 seconds to load)

dblock
dblock reviewed Nov 14, 2014
View reviewed changes
CHANGELOG.md
@@ -1,7 +1,7 @@
Next Release
============

* Your contribution here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put that line back at the bottom of the list :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops

@dblock
Copy link
Member

dblock commented Nov 14, 2014

This makes sense, can you please fix the typos and squash your commits?

@zbelzer
Copy link
Contributor Author

zbelzer commented Nov 14, 2014

Travis build failures look unrelated. Anything else before this is good to go?

dblock added a commit that referenced this pull request Nov 14, 2014
@dblock
Merge pull request #98 from zbelzer/respect_conditions
85220f5 
Respect nested conditions
@dblock dblock merged commit 85220f5 into ruby-grape:master Nov 14, 2014
@dblock
Copy link
Member

dblock commented Nov 14, 2014

Merged.

@zbelzer zbelzer deleted the respect_conditions branch November 14, 2014 22:45
@zbelzer
Copy link
Contributor Author

zbelzer commented Nov 14, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zbelzer @dblock