This definitely needs a spec and a CHANGELOG entry, please.

Bump @chrisbloom7.

👍
I was also troubled with the same problem.

@dblock I'll make a note to add tests. Do I just add an entry at the top of the Changelog?

Yes, please @chrisbloom7.

Bump @chrisbloom7 ?

It's still a real problem. You sure you don't want to finish this?

Oh, really? I figured at 5 years old it would have been addressed somewhere along the line. I haven't used Grape in a while, but if you think the fix for this is still relatively the same in the latest version then I can try to find some time to push it through.

Yes, I think it's still a problem and a worthy fix/addition.

@dblock tests added and changelog updated

Coverage remained the same at 100.0% when pulling 5e3a24b on chrisbloom7:patch-1 into 359298a on ruby-grape:master.

Coverage remained the same at 100.0% when pulling 481f4e9 on chrisbloom7:patch-1 into 359298a on ruby-grape:master.

@dblock I'm digging a little deeper into what env['api.format'] represents and it turns out it's not always going to be the value of default_format. According to https://github.com/ruby-grape/grape#api-formats:

The response format (and thus the automatic serialization) is determined in the following order:

• Use the file extension, if specified. If the file is .json, choose the JSON format.
• Use the value of the format parameter in the query string, if specified.
• Use the format set by the format option, if specified.
• Attempt to find an acceptable format from the Accept header.
• Use the default format, if specified by the default_format option.
• Default to :txt

I think it still makes sense to use env['api.format'] to determine what to fall back to. I'll expand the tests to ensure these are all exercised and update the CHANGELOG and README accordingly to say that it's based on the default response as determined by Grape as opposed to the default_format option specifically.

Merged, this is perfect.

@chrisbloom7 Want to join the (co)maintainers group and make a release? Shoot me an email to dblock at dblock dot org with your rubygems email if you're into it.