Create a preset option to set sane default behavior (WIP) #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://ruby2js-pr-178.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cc24r8ta499cqktnis2g. |
|
Hmm, the CI test doesn't seem to be executing the most up-to-date build of the Opal version, seems to be using whatever's on NPM… |
esbuild: use Ruby platform
New configuration DSL and per-file magic comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #171
The docs site is actually broken on Render, so I need to upgrade Bridgetown in a separate PR and add documentation then (and update the live demo). Gist of it is you can run:
And automatically get output with the following options:
str === valeven with double-equals in Ruby)@a = 123->this._a = 123)I gave some thought to other possible filters and options, but this feels like a pretty solid baseline. And with the "magic comments" feature (see #172), it'll be easy to set additional options on a per-file basis as needed.
Thoughts?