Suppress args for getters on super calls #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

esb wants to merge 2 commits into ruby2js:master from esb:esb/issue211

esb commented May 21, 2024

Getter methods should respect the get status on generated super calls. This means that the super call should not include any argument syntax.


          Supress args for getters on super calls

esb changed the title ~~Supress args for getters on super calls~~ Suppress args for getters on super calls

Member

jaredcwhite commented May 22, 2024

Thanks @esb! Could you add a test case to verify? I imagine it would go in es2015_spec.rb (seems most class-related code is tested there).


          Add test cases

0cf1ef4

jaredcwhite assigned jaredcwhite and unassigned jaredcwhite

jaredcwhite self-requested a review

July 3, 2024 00:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet