Support for phtml FileType #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So why not use the PHP scanner? |
|
Because it's mostly javascript and HTML in the file. |
|
Okay, but the PHP scanner already supports HTML with JavaScript… |
|
Can you please check if |
|
Yep it works great. Sorry for the delays Alexandre Vézina On Sun, Apr 7, 2013 at 5:34 AM, Kornelius Kalnbach <notifications@github.com
|
|
Okay, great! I'll merge the PR when you update it accordingly. |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases, phtml files are html/javascripts with small PHP content.
I regesitered the filetype.