Skip to content

Fix minor issue with CSS scanner #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2012
Merged

Fix minor issue with CSS scanner #13

merged 3 commits into from
Jan 21, 2012

Conversation

noprompt
Copy link
Contributor

The block dealing with css functions sets begin_group and end_group as :string instead of :function. I'm assuming this isn't the desired result.

@@ -2,9 +2,9 @@ module CodeRay
module Scanners

class CSS < Scanner

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove all these white-space changes, please? ;)

@korny
Copy link
Member

korny commented Jan 20, 2012

Thanks! I really like the change. The output looks better, and the token type is more logical. If you clean up the changes, I will merge this :-)

@noprompt
Copy link
Contributor Author

Sure! My Vim configuration is a bit aggressive when it comes to stripping whitespace. :P

@noprompt
Copy link
Contributor Author

Alrighty! I think that should do it.

korny added a commit that referenced this pull request Jan 21, 2012
Highlight CSS functions as :function
@korny korny merged commit 185c422 into rubychan:master Jan 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants