Go scanner #147
Merged
Go scanner #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft version, copy from c
Conflicts: lib/coderay/helpers/file_type.rb
Conflicts: lib/coderay/scanners/go.rb
|
Wow, thanks for starting this, @nathany :-) Just tell me when you need support. |
|
@korny I did a little bit, but it still needs work. Back to you. :-) |
|
Ah, so that's why you assigned it to me ;-) |
Closed
|
Okay, I fixed the remaining issues from your list. Looks good enough for my eyes now. Additional tweak for the Go scanner are always welcome though! |
|
Awesome. Thanks @korny |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tweaked version of #28.
TODO:
1.e+0iAlso for reference: https://github.com/jayferd/rouge/blob/master/lib/rouge/lexers/go.rb