Skip to content

Removed redundant raise #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2012
Merged

Removed redundant raise #20

merged 1 commit into from
Apr 5, 2012

Conversation

TildeWill
Copy link
Contributor

It's covered by the require which raises a LoadError if the file does not exist

…ms when included in other gems and returns false when files are indeed present.
@TildeWill
Copy link
Contributor Author

Here's a gist showing my attempt to use Coderay in rspec_api_documentation and my failing rspec spec where the scanners are not loaded: https://gist.github.com/2279150

@TildeWill
Copy link
Contributor Author

And for something you can actually run, just clone my fork of rspec_api_documentation and run rake... you should get 5 errors, all with the same error:

 CodeRay::PluginHost::PluginNotFound:
   CodeRay::Scanners could not load plugin :json: /Users/readwl/.rvm/gems/ruby-1.9.2-p180@rspecapidocumentation/gems/coderay-1.0.5/lib/coderay/scanners/json.rb not found

and you can see the file does exist

$ ls -la /Users/readwl/.rvm/gems/ruby-1.9.2-p180@rspecapidocumentation/gems/coderay-1.0.5/lib/coderay/scanners/json.rb
-rw-r--r-- 1 readwl staff 2833 Apr 1 18:22 /Users/readwl/.rvm/gems/ruby-1.9.2-p180@rspecapidocumentation/gems/coderay-1.0.5/lib/coderay/scanners/json.rb

I'd really like to get this resolved soon so I can move on with my changes to rspec_api_documentation and kick off a pull request there. Thanks!

@ghost ghost assigned korny Apr 5, 2012
@korny
Copy link
Member

korny commented Apr 5, 2012

I guess the original reason for the line was debugging. I'll merge it for 1.0.7 later.

korny added a commit that referenced this pull request Apr 5, 2012
@korny korny merged commit 68d7680 into rubychan:master Apr 5, 2012
@korny
Copy link
Member

korny commented Apr 5, 2012

1.0.7.rc1 fixes the CodeRay errors in the rspec_api_documentation tests on my system. Can you confirm?

@TildeWill
Copy link
Contributor Author

Confirmed. Thanks for pulling this in.

@korny
Copy link
Member

korny commented Jun 20, 2012

Sorry, I just forgot to release it –_–' 1.0.7 will come in the next days, along with another fix.

@korny
Copy link
Member

korny commented Jun 25, 2012

It's released now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants