Skip to content

Port tests and fixes from Node 17 to Node 18 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jan 31, 2023

Conversation

Fayti1703
Copy link
Contributor

Ports #41 to node-18 branch.

Fayti1703 and others added 19 commits January 31, 2023 08:34
Build the symbol table after adding each file instead of continually
rebuilding it.
This fixes an issue where functions that require ICU data segfault
the process due to an unexpected lack of ICU data.

The actual ICU data is provided by the icudt71_dat object.
Linking on Linux currently errors with `undefined reference to `'dlsym'`
Alpine Linux's `ar` program doesn't support having objects with the
same name in the archive twice, so we have to use the GNU extension
for including paths.

This commit *should* honestly be split into multiple separate commits,
but unfortunately pretty much all of these changes have to be applied
as a unit or a build step fails.
Let node figure out the snake business.
@Fayti1703
Copy link
Contributor Author

@Fayti1703 Fayti1703 marked this pull request as ready for review January 31, 2023 10:33
@lloeki lloeki merged commit c942cbb into rubyjs:node-18 Jan 31, 2023
@lloeki
Copy link
Collaborator

lloeki commented Jan 31, 2023

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants