Fix ECONNRESET error emitted after failed connect (brianc#1230)

magnushiie · brianc · commit 197f86f90dec · 2017-03-20T12:01:41.000-05:00
On Windows, after a connect attempt has failed, an error event with ECONNRESET is emitted after the real connect error is propagated to the connect callback, because the connection is not in ending state (connection._ending) where ECONNRESET is ignored. This change ends the connection when connect has failed. This fixes brianc#746.
diff --git a/lib/client.js b/lib/client.js
@@ -182,6 +182,7 @@ Client.prototype.connect = function(callback) {
     if(!callback) {
       return self.emit('error', error);
     }
+    con.end(); // make sure ECONNRESET errors don't cause error events
     callback(error);
     callback = null;
   });

Original file line number	Diff line number	Diff line change
`@@ -182,6 +182,7 @@ Client.prototype.connect = function(callback) {`
`182`	`182`	`if(!callback) {`
`183`	`183`	`return self.emit('error', error);`
`184`	`184`	`}`
	`185`	`+ con.end(); // make sure ECONNRESET errors don't cause error events`
`185`	`186`	`callback(error);`
`186`	`187`	`callback = null;`
`187`	`188`	`});`