Skip to content

Drop Ruby 1.9 support in changelog and gemspec #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Drop Ruby 1.9 support in changelog and gemspec #256

wants to merge 1 commit into from

Conversation

mnaberez
Copy link
Contributor

Ruby 1.9 support was silently dropped in 0cbae14 (see issue #254). Support for a major Ruby version should not be dropped without notifying users. If Ruby 1.9 support is to be dropped, please update the Rubyzip major version, changelog, and gemspec.

cc: @agrimm @hainesr @simonoff

@simonoff
Copy link
Member

I don't see any reasons in that. What it will give up? Nothing. Ruby Core team already not supported them. So IF anyone will have issues with Ruby 1.9 then we can think something. But again it's not supported software.

@mnaberez
Copy link
Contributor Author

Ruby 1.9.3 came out of official support this year but that doesn't mean every deployment of it immediately disappeared. It was a stable Ruby version that was run by production applications for years. Some users may still be transitioning for various reasons.

Please do one of the following:

You have silently dropped CI testing on 1.9.3 in 0cbae14. Any change you make may break 1.9.3 and you won't know. Users do not know you have dropped 1.9.3 support because you haven't communicated it to them in the changelog, gemspec, or version. Users running on 1.9.3 may upgrade via bundle update and suddenly find their app is broken because of Rubyzip. There's not a changelog entry to help them figure out why and the gemspec still says 1.9.3 is supported.

@hainesr
Copy link
Member

hainesr commented Nov 11, 2015

I agree that the major version number should have been bumped if support for 1.9.x was dropped. So why not do it now and keep the 1.1.x branch for fixes needed by 1.9.x if necessary?

@coveralls
Copy link

coveralls commented Jun 4, 2017

Coverage Status

Coverage remained the same at 91.384% when pulling 95b0410 on mnaberez:drop-ruby19 into 98f4f2e on rubyzip:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.384% when pulling 95b0410 on mnaberez:drop-ruby19 into 98f4f2e on rubyzip:master.

@mnaberez
Copy link
Contributor Author

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants