-
Notifications
You must be signed in to change notification settings - Fork 313
Save temporary files to a temporary directory #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
210a26a
to
258ef02
Compare
2 similar comments
Should I maintain or increase coverage for this patch to be merged? Since this patch implements correct (or recommended) arguments to Ruby built-in library, IMHO there seems to be no strong requirements to keep the coverage. Also, the fact the coverage decrease from https://coveralls.io/builds/10052092 (recent master push) to https://coveralls.io/builds/12143274 (this branch) is due to increased number of relevant lines from 2031 to 2032. This is actually triggered by counting I just would like to stop temporary files from filling up application's root directory. 🐱 |
Hello. It's been a while since I submitted this PR, and I'm wondering if there is anything I could do on my end. I totally understand you are busy and require more time to consider, it is much appreciated if you could give me a response. |
Thank you very much!!! |
I would like to save temporary files to a temporary directory.
Because the primary objective of
@temp_file
inZip::StreamableStream
is to temporarily hold data of an entry as a file, the upper directory does not need to be the current directory.This patch set the directory to default
Dir.tmpdir
. As a result, we can stop temporary files from filling up current directory.c.f. http://ruby-doc.org/stdlib-2.4.1/libdoc/tempfile/rdoc/Tempfile.html