Skip to content

Travis: JRuby code coverage possible using the --debug flag, drop a failing JDK variant, use Rubinius rbx-3 #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 7, 2017
Merged

Travis: JRuby code coverage possible using the --debug flag, drop a failing JDK variant, use Rubinius rbx-3 #346

merged 7 commits into from
Dec 7, 2017

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Nov 28, 2017 •
edited
Loading

  • use latest JRuby 9.1.14.0
  • enable --debug for JRuby - this makes the code coverage counting be realistic
  • drop oraclejdk-7 as a JRuby target - it was always failing
  • change Rubinius to use rbx-3 - which has a Bundler issue - this makes me keep it in the allow_failures list

@coveralls
Copy link

coveralls commented Nov 28, 2017 •
edited
Loading

Coverage Status

Coverage increased (+1.5%) to 92.925% when pulling 43f01f4 on olleolleolle:patch-2 into 57c3772 on rubyzip:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 92.925% when pulling 43f01f4 on olleolleolle:patch-2 into 57c3772 on rubyzip:master.

@coveralls
Copy link

coveralls commented Nov 28, 2017 •
edited
Loading

Coverage Status

Coverage increased (+1.3%) to 92.647% when pulling e65bc45 on olleolleolle:patch-2 into 57c3772 on rubyzip:master.

@coveralls
Copy link

coveralls commented Nov 28, 2017 •
edited
Loading

Coverage Status

Coverage increased (+1.3%) to 92.647% when pulling cbdea2a on olleolleolle:patch-2 into 57c3772 on rubyzip:master.

@coveralls
Copy link

coveralls commented Nov 28, 2017 •
edited
Loading

Coverage Status

Coverage increased (+1.3%) to 92.647% when pulling cbdea2a on olleolleolle:patch-2 into 57c3772 on rubyzip:master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 28, 2017 •
edited
Loading

Coverage Status

Coverage increased (+1.3%) to 92.647% when pulling cbdea2a on olleolleolle:patch-2 into 57c3772 on rubyzip:master.

@olleolleolle
Copy link
Contributor Author

@simonoff We can get to green with this one. And have a faster build.

@coveralls
Copy link

coveralls commented Nov 28, 2017 •
edited
Loading

Coverage Status

Coverage increased (+1.3%) to 92.647% when pulling 849e774 on olleolleolle:patch-2 into 57c3772 on rubyzip:master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 28, 2017 •
edited
Loading

Coverage Status

Coverage increased (+1.3%) to 92.647% when pulling 849e774 on olleolleolle:patch-2 into 57c3772 on rubyzip:master.

@coveralls
Copy link

coveralls commented Nov 28, 2017 •
edited
Loading

Coverage Status

Coverage increased (+1.3%) to 92.647% when pulling 75cd0dc on olleolleolle:patch-2 into 57c3772 on rubyzip:master.

@olleolleolle olleolleolle changed the title Travis: use pre-installed Travis rubies Travis: JRuby code coverage possible using the --debug flag, drop a failing JDK variant, use Rubinius rbx-3 Dec 7, 2017
@olleolleolle
Copy link
Contributor Author

@simonoff You wanted to test on the latest versions, that's great, too.

I resolved the conflicts on this PR.

@coveralls
Copy link

coveralls commented Dec 7, 2017 •
edited
Loading

Coverage Status

Coverage increased (+1.2%) to 92.647% when pulling ea98fa1 on olleolleolle:patch-2 into 2f6bc8e on rubyzip:master.

@simonoff simonoff merged commit 2f6b47d into rubyzip:master Dec 7, 2017
@olleolleolle olleolleolle deleted the patch-2 branch December 7, 2017 13:22
@jdleesmiller jdleesmiller mentioned this pull request Mar 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olleolleolle @coveralls @simonoff