Fix regression caused by automatic Rubocop fixes #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
InputStream: ``` if @current_entry && @current_entry.gp_flags & 8 == 8 && @current_entry.crc == 0 \ && @current_entry.compressed_size == 0 \ && @current_entry.empty? && !@internal ``` `Zip::Entry#empty?` doesn't exist, but an automatic Rubocop check thought it should be converted from `size == 0`. Unfortunately, this is tricky to write a test for as it only fails under some very specific conditions.
5f43552 to
ffd0b67
Compare
|
Came here to patch the same thing! @olleolleolle @simonoff Could one of you merge this? |
This was referenced Mar 11, 2021
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zip::Entry.empty?doesn't exist, but Rubocop suggested it as a fix instead ofsize == 0. This particular instance only fails under very certain circumstances. I have a file that causes it to fail but it's an proprietary internal file that's automatically generated by one of our vendors so I'm unable to share it.I only fixed this one specific instance, there may be other regressions caused by the Rubocop cleanup so perhaps the entire commit should be double-checked.