Handle stored files with general purpose bit 3 set #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Coward <scoward@pivotal.io>
5 tasks
|
@simonoff @olleolleolle any feedback? We'd like to use rubyzip in Cloud Foundry's Cloud Controller, but we're blocked on this PR. |
|
Thanks! |
5 tasks
This was referenced Oct 12, 2019
This was referenced Oct 17, 2019
This was referenced Dec 2, 2019
This was referenced Mar 11, 2021
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In these cases, the
@current_entryis unpacked from the local headers, but the size/compressed size/crc are all set to 0, which causes thePassThruDecompressorto read no bytes instead of the entry size.This change makes
Entry#get_input_streampass theEntryitself down toZip::InputStreamso that when creating the Decompressor, it can be constructed with the correct number of bytes to be read (iff general purpose bit 3 is set and the size is 0).May be related to #236 #295
Signed-off-by: Sam Coward scoward@pivotal.io