Print library warnings to stderr with warn (not puts).
#416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`warn` has the advantage of easily being disabled by, the `-W0` interpreter flag or setting $VERBOSE to nil.
And fix a few spelling mistakes.
Check that they say the right things and are on stderr, not stdout. A nice side effect of this is that it cleans up the test output.
jdleesmiller
added a commit
that referenced
this pull request
Oct 19, 2019
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the advantage of consistency and being able to turn them off with, e.g.
-W0.Also, make the messages themselves more consistent and check that they are actually output.
(@jdleesmiller I mentioned a while back in another PR that I would work this one up.)