Skip to content

Reinstate normalising pathname separators to /. #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

hainesr
Copy link
Member

@hainesr hainesr commented Jun 2, 2021

But only do it after we have set filename encoding appropriately to
avoid breaking multibyte characters with \s in them.

Fixes #324.

But only do it after we have set filename encoding appropriately to
avoid breaking multibyte characters with `\`s in them.

Fixes rubyzip#324.
@coveralls
Copy link

coveralls commented Jun 2, 2021

Coverage Status

Coverage increased (+0.002%) to 96.731% when pulling 529634e on hainesr:fix-pathname-regression into 1777a3f on rubyzip:master.

@hainesr hainesr merged commit 22a5485 into rubyzip:master Jun 4, 2021
@hainesr hainesr deleted the fix-pathname-regression branch June 4, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible regression from 1.2.0 to 1.2.1 when ZIP entry's filename contains backslash
2 participants