Skip to content

Commit 2425bb3

Browse files
author
Mauro Carvalho Chehab
committed
em28xx: regression fix: use DRX-K sync firmware requests on em28xx
As em28xx-dvb will always be initialized asynchronously, there's no need anymore for a separate thread to load the DRX-K firmware. Fixes a known regression with kernel 3.6 with tda18271 driver and asynchronous DRX-K firmware load. Antti tested it with the following hardware: Hauppauge WinTV HVR 930C MaxMedia UB425-TC PCTV QuatroStick nano (520e) Tested-by: Antti Palosaari <crope@iki.fi> Cc: stable@kernel.org # for Kernel 3.6 - please note that driver location has changed Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
1 parent 8e30783 commit 2425bb3

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

drivers/media/usb/em28xx/em28xx-dvb.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,7 @@ static struct drxk_config terratec_h5_drxk = {
318318
.no_i2c_bridge = 1,
319319
.microcode_name = "dvb-usb-terratec-h5-drxk.fw",
320320
.qam_demod_parameter_count = 2,
321+
.load_firmware_sync = true,
321322
};
322323

323324
static struct drxk_config hauppauge_930c_drxk = {
@@ -327,6 +328,7 @@ static struct drxk_config hauppauge_930c_drxk = {
327328
.microcode_name = "dvb-usb-hauppauge-hvr930c-drxk.fw",
328329
.chunk_size = 56,
329330
.qam_demod_parameter_count = 2,
331+
.load_firmware_sync = true,
330332
};
331333

332334
struct drxk_config terratec_htc_stick_drxk = {
@@ -340,12 +342,14 @@ struct drxk_config terratec_htc_stick_drxk = {
340342
.antenna_dvbt = true,
341343
/* The windows driver uses the same. This will disable LNA. */
342344
.antenna_gpio = 0x6,
345+
.load_firmware_sync = true,
343346
};
344347

345348
static struct drxk_config maxmedia_ub425_tc_drxk = {
346349
.adr = 0x29,
347350
.single_master = 1,
348351
.no_i2c_bridge = 1,
352+
.load_firmware_sync = true,
349353
};
350354

351355
static struct drxk_config pctv_520e_drxk = {
@@ -356,6 +360,7 @@ static struct drxk_config pctv_520e_drxk = {
356360
.chunk_size = 58,
357361
.antenna_dvbt = true, /* disable LNA */
358362
.antenna_gpio = (1 << 2), /* disable LNA */
363+
.load_firmware_sync = true,
359364
};
360365

361366
static int drxk_gate_ctrl(struct dvb_frontend *fe, int enable)

0 commit comments

Comments
 (0)