Skip to content

Commit 66c7db6

Browse files
Christoph HellwigNicholas Bellinger
Christoph Hellwig
authored and
Nicholas Bellinger
committed
iscsit: use the itt_t abstract type
Use the special itt_t type defined by the iscsi headers and the initiator to make sure it's an opaque value. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
1 parent cea0b4c commit 66c7db6

10 files changed

+37
-46
lines changed

‎drivers/target/iscsi/iscsi_target.c

Lines changed: 14 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -785,7 +785,6 @@ static int iscsit_handle_scsi_cmd(
785785

786786
hdr = (struct iscsi_scsi_req *) buf;
787787
payload_length = ntoh24(hdr->dlength);
788-
hdr->itt = be32_to_cpu(hdr->itt);
789788
hdr->data_length = be32_to_cpu(hdr->data_length);
790789
hdr->cmdsn = be32_to_cpu(hdr->cmdsn);
791790
hdr->exp_statsn = be32_to_cpu(hdr->exp_statsn);
@@ -1194,7 +1193,6 @@ static int iscsit_handle_data_out(struct iscsi_conn *conn, unsigned char *buf)
11941193

11951194
hdr = (struct iscsi_data *) buf;
11961195
payload_length = ntoh24(hdr->dlength);
1197-
hdr->itt = be32_to_cpu(hdr->itt);
11981196
hdr->ttt = be32_to_cpu(hdr->ttt);
11991197
hdr->exp_statsn = be32_to_cpu(hdr->exp_statsn);
12001198
hdr->datasn = be32_to_cpu(hdr->datasn);
@@ -1425,12 +1423,11 @@ static int iscsit_handle_nop_out(
14251423

14261424
hdr = (struct iscsi_nopout *) buf;
14271425
payload_length = ntoh24(hdr->dlength);
1428-
hdr->itt = be32_to_cpu(hdr->itt);
14291426
hdr->ttt = be32_to_cpu(hdr->ttt);
14301427
hdr->cmdsn = be32_to_cpu(hdr->cmdsn);
14311428
hdr->exp_statsn = be32_to_cpu(hdr->exp_statsn);
14321429

1433-
if ((hdr->itt == 0xFFFFFFFF) && !(hdr->opcode & ISCSI_OP_IMMEDIATE)) {
1430+
if (hdr->itt == RESERVED_ITT && !(hdr->opcode & ISCSI_OP_IMMEDIATE)) {
14341431
pr_err("NOPOUT ITT is reserved, but Immediate Bit is"
14351432
" not set, protocol error.\n");
14361433
return iscsit_add_reject(ISCSI_REASON_PROTOCOL_ERROR, 1,
@@ -1448,7 +1445,7 @@ static int iscsit_handle_nop_out(
14481445

14491446
pr_debug("Got NOPOUT Ping %s ITT: 0x%08x, TTT: 0x%09x,"
14501447
" CmdSN: 0x%08x, ExpStatSN: 0x%08x, Length: %u\n",
1451-
(hdr->itt == 0xFFFFFFFF) ? "Response" : "Request",
1448+
hdr->itt == RESERVED_ITT ? "Response" : "Request",
14521449
hdr->itt, hdr->ttt, hdr->cmdsn, hdr->exp_statsn,
14531450
payload_length);
14541451
/*
@@ -1556,7 +1553,7 @@ static int iscsit_handle_nop_out(
15561553
pr_debug("Ping Data: \"%s\"\n", ping_data);
15571554
}
15581555

1559-
if (hdr->itt != 0xFFFFFFFF) {
1556+
if (hdr->itt != RESERVED_ITT) {
15601557
if (!cmd) {
15611558
pr_err("Checking CmdSN for NOPOUT,"
15621559
" but cmd is NULL!\n");
@@ -1639,8 +1636,6 @@ static int iscsit_handle_task_mgt_cmd(
16391636
u8 function;
16401637

16411638
hdr = (struct iscsi_tm *) buf;
1642-
hdr->itt = be32_to_cpu(hdr->itt);
1643-
hdr->rtt = be32_to_cpu(hdr->rtt);
16441639
hdr->cmdsn = be32_to_cpu(hdr->cmdsn);
16451640
hdr->exp_statsn = be32_to_cpu(hdr->exp_statsn);
16461641
hdr->refcmdsn = be32_to_cpu(hdr->refcmdsn);
@@ -1655,9 +1650,9 @@ static int iscsit_handle_task_mgt_cmd(
16551650

16561651
if ((function != ISCSI_TM_FUNC_ABORT_TASK) &&
16571652
((function != ISCSI_TM_FUNC_TASK_REASSIGN) &&
1658-
(hdr->rtt != ISCSI_RESERVED_TAG))) {
1653+
hdr->rtt != RESERVED_ITT)) {
16591654
pr_err("RefTaskTag should be set to 0xFFFFFFFF.\n");
1660-
hdr->rtt = ISCSI_RESERVED_TAG;
1655+
hdr->rtt = RESERVED_ITT;
16611656
}
16621657

16631658
if ((function == ISCSI_TM_FUNC_TASK_REASSIGN) &&
@@ -1869,7 +1864,6 @@ static int iscsit_handle_text_cmd(
18691864

18701865
hdr = (struct iscsi_text *) buf;
18711866
payload_length = ntoh24(hdr->dlength);
1872-
hdr->itt = be32_to_cpu(hdr->itt);
18731867
hdr->ttt = be32_to_cpu(hdr->ttt);
18741868
hdr->cmdsn = be32_to_cpu(hdr->cmdsn);
18751869
hdr->exp_statsn = be32_to_cpu(hdr->exp_statsn);
@@ -2131,7 +2125,6 @@ static int iscsit_handle_logout_cmd(
21312125

21322126
hdr = (struct iscsi_logout *) buf;
21332127
reason_code = (hdr->flags & 0x7f);
2134-
hdr->itt = be32_to_cpu(hdr->itt);
21352128
hdr->cid = be16_to_cpu(hdr->cid);
21362129
hdr->cmdsn = be32_to_cpu(hdr->cmdsn);
21372130
hdr->exp_statsn = be32_to_cpu(hdr->exp_statsn);
@@ -2219,7 +2212,6 @@ static int iscsit_handle_snack(
22192212

22202213
hdr = (struct iscsi_snack *) buf;
22212214
hdr->flags &= ~ISCSI_FLAG_CMD_FINAL;
2222-
hdr->itt = be32_to_cpu(hdr->itt);
22232215
hdr->ttt = be32_to_cpu(hdr->ttt);
22242216
hdr->exp_statsn = be32_to_cpu(hdr->exp_statsn);
22252217
hdr->begrun = be32_to_cpu(hdr->begrun);
@@ -2414,7 +2406,7 @@ static int iscsit_send_conn_drop_async_message(
24142406
hdr = (struct iscsi_async *) cmd->pdu;
24152407
hdr->opcode = ISCSI_OP_ASYNC_EVENT;
24162408
hdr->flags = ISCSI_FLAG_CMD_FINAL;
2417-
cmd->init_task_tag = 0xFFFFFFFF;
2409+
cmd->init_task_tag = RESERVED_ITT;
24182410
cmd->targ_xfer_tag = 0xFFFFFFFF;
24192411
put_unaligned_be64(0xFFFFFFFFFFFFFFFFULL, &hdr->rsvd4[0]);
24202412
cmd->stat_sn = conn->stat_sn++;
@@ -2536,7 +2528,7 @@ static int iscsit_send_data_in(
25362528
else
25372529
put_unaligned_le64(0xFFFFFFFFFFFFFFFFULL, &hdr->lun);
25382530

2539-
hdr->itt = cpu_to_be32(cmd->init_task_tag);
2531+
hdr->itt = cmd->init_task_tag;
25402532
hdr->ttt = (hdr->flags & ISCSI_FLAG_DATA_ACK) ?
25412533
cpu_to_be32(cmd->targ_xfer_tag) :
25422534
0xFFFFFFFF;
@@ -2708,7 +2700,7 @@ static int iscsit_send_logout_response(
27082700
hdr->opcode = ISCSI_OP_LOGOUT_RSP;
27092701
hdr->flags |= ISCSI_FLAG_CMD_FINAL;
27102702
hdr->response = cmd->logout_response;
2711-
hdr->itt = cpu_to_be32(cmd->init_task_tag);
2703+
hdr->itt = cmd->init_task_tag;
27122704
cmd->stat_sn = conn->stat_sn++;
27132705
hdr->statsn = cpu_to_be32(cmd->stat_sn);
27142706

@@ -2759,7 +2751,7 @@ static int iscsit_send_unsolicited_nopin(
27592751
memset(hdr, 0, ISCSI_HDR_LEN);
27602752
hdr->opcode = ISCSI_OP_NOOP_IN;
27612753
hdr->flags |= ISCSI_FLAG_CMD_FINAL;
2762-
hdr->itt = cpu_to_be32(cmd->init_task_tag);
2754+
hdr->itt = cmd->init_task_tag;
27632755
hdr->ttt = cpu_to_be32(cmd->targ_xfer_tag);
27642756
cmd->stat_sn = conn->stat_sn;
27652757
hdr->statsn = cpu_to_be32(cmd->stat_sn);
@@ -2816,7 +2808,7 @@ static int iscsit_send_nopin_response(
28162808
hdr->flags |= ISCSI_FLAG_CMD_FINAL;
28172809
hton24(hdr->dlength, cmd->buf_ptr_size);
28182810
put_unaligned_le64(0xFFFFFFFFFFFFFFFFULL, &hdr->lun);
2819-
hdr->itt = cpu_to_be32(cmd->init_task_tag);
2811+
hdr->itt = cmd->init_task_tag;
28202812
hdr->ttt = cpu_to_be32(cmd->targ_xfer_tag);
28212813
cmd->stat_sn = conn->stat_sn++;
28222814
hdr->statsn = cpu_to_be32(cmd->stat_sn);
@@ -2906,7 +2898,7 @@ static int iscsit_send_r2t(
29062898
hdr->flags |= ISCSI_FLAG_CMD_FINAL;
29072899
int_to_scsilun(cmd->se_cmd.orig_fe_lun,
29082900
(struct scsi_lun *)&hdr->lun);
2909-
hdr->itt = cpu_to_be32(cmd->init_task_tag);
2901+
hdr->itt = cmd->init_task_tag;
29102902
spin_lock_bh(&conn->sess->ttt_lock);
29112903
r2t->targ_xfer_tag = conn->sess->targ_xfer_tag++;
29122904
if (r2t->targ_xfer_tag == 0xFFFFFFFF)
@@ -3074,7 +3066,7 @@ static int iscsit_send_status(
30743066
}
30753067
hdr->response = cmd->iscsi_response;
30763068
hdr->cmd_status = cmd->se_cmd.scsi_status;
3077-
hdr->itt = cpu_to_be32(cmd->init_task_tag);
3069+
hdr->itt = cmd->init_task_tag;
30783070
hdr->statsn = cpu_to_be32(cmd->stat_sn);
30793071

30803072
iscsit_increment_maxcmdsn(cmd, conn->sess);
@@ -3187,7 +3179,7 @@ static int iscsit_send_task_mgt_rsp(
31873179
hdr->opcode = ISCSI_OP_SCSI_TMFUNC_RSP;
31883180
hdr->flags = ISCSI_FLAG_CMD_FINAL;
31893181
hdr->response = iscsit_convert_tcm_tmr_rsp(se_tmr);
3190-
hdr->itt = cpu_to_be32(cmd->init_task_tag);
3182+
hdr->itt = cmd->init_task_tag;
31913183
cmd->stat_sn = conn->stat_sn++;
31923184
hdr->statsn = cpu_to_be32(cmd->stat_sn);
31933185

@@ -3360,7 +3352,7 @@ static int iscsit_send_text_rsp(
33603352
hdr->opcode = ISCSI_OP_TEXT_RSP;
33613353
hdr->flags |= ISCSI_FLAG_CMD_FINAL;
33623354
hton24(hdr->dlength, text_length);
3363-
hdr->itt = cpu_to_be32(cmd->init_task_tag);
3355+
hdr->itt = cmd->init_task_tag;
33643356
hdr->ttt = cpu_to_be32(cmd->targ_xfer_tag);
33653357
cmd->stat_sn = conn->stat_sn++;
33663358
hdr->statsn = cpu_to_be32(cmd->stat_sn);

‎drivers/target/iscsi/iscsi_target_configfs.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1475,7 +1475,8 @@ static u32 iscsi_get_task_tag(struct se_cmd *se_cmd)
14751475
{
14761476
struct iscsi_cmd *cmd = container_of(se_cmd, struct iscsi_cmd, se_cmd);
14771477

1478-
return cmd->init_task_tag;
1478+
/* only used for printks or comparism with ->ref_task_tag */
1479+
return (__force u32)cmd->init_task_tag;
14791480
}
14801481

14811482
static int iscsi_get_cmd_state(struct se_cmd *se_cmd)

‎drivers/target/iscsi/iscsi_target_core.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ struct iscsi_cmd {
361361
/* Command flags */
362362
enum cmd_flags_table cmd_flags;
363363
/* Initiator Task Tag assigned from Initiator */
364-
u32 init_task_tag;
364+
itt_t init_task_tag;
365365
/* Target Transfer Tag assigned from Target */
366366
u32 targ_xfer_tag;
367367
/* CmdSN assigned from Initiator */
@@ -506,7 +506,7 @@ struct iscsi_conn {
506506
u32 auth_id;
507507
u32 conn_flags;
508508
/* Used for iscsi_tx_login_rsp() */
509-
u32 login_itt;
509+
itt_t login_itt;
510510
u32 exp_statsn;
511511
/* Per connection status sequence number */
512512
u32 stat_sn;
@@ -599,7 +599,7 @@ struct iscsi_session {
599599
/* state session is currently in */
600600
u32 session_state;
601601
/* session wide counter: initiator assigned task tag */
602-
u32 init_task_tag;
602+
itt_t init_task_tag;
603603
/* session wide counter: target assigned task tag */
604604
u32 targ_xfer_tag;
605605
u32 cmdsn_window;
@@ -665,7 +665,7 @@ struct iscsi_login {
665665
u8 version_max;
666666
char isid[6];
667667
u32 cmd_sn;
668-
u32 init_task_tag;
668+
itt_t init_task_tag;
669669
u32 initial_exp_statsn;
670670
u32 rsp_length;
671671
u16 cid;

‎drivers/target/iscsi/iscsi_target_erl1.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,7 @@ static int iscsit_handle_recovery_datain(
466466
int iscsit_handle_recovery_datain_or_r2t(
467467
struct iscsi_conn *conn,
468468
unsigned char *buf,
469-
u32 init_task_tag,
469+
itt_t init_task_tag,
470470
u32 targ_xfer_tag,
471471
u32 begrun,
472472
u32 runlength)
@@ -498,7 +498,7 @@ int iscsit_handle_recovery_datain_or_r2t(
498498
/* #warning FIXME: Status SNACK needs to be dependent on OPCODE!!! */
499499
int iscsit_handle_status_snack(
500500
struct iscsi_conn *conn,
501-
u32 init_task_tag,
501+
itt_t init_task_tag,
502502
u32 targ_xfer_tag,
503503
u32 begrun,
504504
u32 runlength)

‎drivers/target/iscsi/iscsi_target_erl1.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ extern int iscsit_create_recovery_datain_values_datasequenceinorder_yes(
77
extern int iscsit_create_recovery_datain_values_datasequenceinorder_no(
88
struct iscsi_cmd *, struct iscsi_datain_req *);
99
extern int iscsit_handle_recovery_datain_or_r2t(struct iscsi_conn *, unsigned char *,
10-
u32, u32, u32, u32);
11-
extern int iscsit_handle_status_snack(struct iscsi_conn *, u32, u32,
10+
itt_t, u32, u32, u32);
11+
extern int iscsit_handle_status_snack(struct iscsi_conn *, itt_t, u32,
1212
u32, u32);
1313
extern int iscsit_handle_data_ack(struct iscsi_conn *, u32, u32, u32);
1414
extern int iscsit_dataout_datapduinorder_no_fbit(struct iscsi_cmd *, struct iscsi_pdu *);

‎drivers/target/iscsi/iscsi_target_login.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -953,9 +953,9 @@ static int __iscsi_target_login_thread(struct iscsi_np *np)
953953
pdu = (struct iscsi_login_req *) buffer;
954954
pdu->cid = be16_to_cpu(pdu->cid);
955955
pdu->tsih = be16_to_cpu(pdu->tsih);
956-
pdu->itt = be32_to_cpu(pdu->itt);
957956
pdu->cmdsn = be32_to_cpu(pdu->cmdsn);
958957
pdu->exp_statsn = be32_to_cpu(pdu->exp_statsn);
958+
959959
/*
960960
* Used by iscsit_tx_login_rsp() for Login Resonses PDUs
961961
* when Status-Class != 0.

‎drivers/target/iscsi/iscsi_target_nego.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -339,14 +339,14 @@ static int iscsi_target_do_tx_login_io(struct iscsi_conn *conn, struct iscsi_log
339339
hton24(login_rsp->dlength, login->rsp_length);
340340
memcpy(login_rsp->isid, login->isid, 6);
341341
login_rsp->tsih = cpu_to_be16(login->tsih);
342-
login_rsp->itt = cpu_to_be32(login->init_task_tag);
342+
login_rsp->itt = login->init_task_tag;
343343
login_rsp->statsn = cpu_to_be32(conn->stat_sn++);
344344
login_rsp->exp_cmdsn = cpu_to_be32(conn->sess->exp_cmd_sn);
345345
login_rsp->max_cmdsn = cpu_to_be32(conn->sess->max_cmd_sn);
346346

347347
pr_debug("Sending Login Response, Flags: 0x%02x, ITT: 0x%08x,"
348348
" ExpCmdSN; 0x%08x, MaxCmdSN: 0x%08x, StatSN: 0x%08x, Length:"
349-
" %u\n", login_rsp->flags, ntohl(login_rsp->itt),
349+
" %u\n", login_rsp->flags, (__force u32)login_rsp->itt,
350350
ntohl(login_rsp->exp_cmdsn), ntohl(login_rsp->max_cmdsn),
351351
ntohl(login_rsp->statsn), login->rsp_length);
352352

@@ -361,7 +361,6 @@ static int iscsi_target_do_tx_login_io(struct iscsi_conn *conn, struct iscsi_log
361361

362362
login->rsp_length = 0;
363363
login_rsp->tsih = be16_to_cpu(login_rsp->tsih);
364-
login_rsp->itt = be32_to_cpu(login_rsp->itt);
365364
login_rsp->statsn = be32_to_cpu(login_rsp->statsn);
366365
mutex_lock(&sess->cmdsn_mutex);
367366
login_rsp->exp_cmdsn = be32_to_cpu(sess->exp_cmd_sn);
@@ -382,7 +381,6 @@ static int iscsi_target_do_rx_login_io(struct iscsi_conn *conn, struct iscsi_log
382381
login_req = (struct iscsi_login_req *) login->req;
383382
payload_length = ntoh24(login_req->dlength);
384383
login_req->tsih = be16_to_cpu(login_req->tsih);
385-
login_req->itt = be32_to_cpu(login_req->itt);
386384
login_req->cid = be16_to_cpu(login_req->cid);
387385
login_req->cmdsn = be32_to_cpu(login_req->cmdsn);
388386
login_req->exp_statsn = be32_to_cpu(login_req->exp_statsn);

‎drivers/target/iscsi/iscsi_target_tmr.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ u8 iscsit_tmr_abort_task(
6161
return ISCSI_TMF_RSP_REJECTED;
6262
}
6363

64-
se_tmr->ref_task_tag = hdr->rtt;
64+
se_tmr->ref_task_tag = (__force u32)hdr->rtt;
6565
tmr_req->ref_cmd = ref_cmd;
6666
tmr_req->ref_cmd_sn = hdr->refcmdsn;
6767
tmr_req->exp_data_sn = hdr->exp_datasn;
@@ -171,7 +171,7 @@ u8 iscsit_tmr_task_reassign(
171171
return ISCSI_TMF_RSP_REJECTED;
172172
}
173173

174-
se_tmr->ref_task_tag = hdr->rtt;
174+
se_tmr->ref_task_tag = (__force u32)hdr->rtt;
175175
tmr_req->ref_cmd = ref_cmd;
176176
tmr_req->ref_cmd_sn = hdr->refcmdsn;
177177
tmr_req->exp_data_sn = hdr->exp_datasn;

‎drivers/target/iscsi/iscsi_target_util.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ int iscsit_check_unsolicited_dataout(struct iscsi_cmd *cmd, unsigned char *buf)
351351

352352
struct iscsi_cmd *iscsit_find_cmd_from_itt(
353353
struct iscsi_conn *conn,
354-
u32 init_task_tag)
354+
itt_t init_task_tag)
355355
{
356356
struct iscsi_cmd *cmd;
357357

@@ -371,7 +371,7 @@ struct iscsi_cmd *iscsit_find_cmd_from_itt(
371371

372372
struct iscsi_cmd *iscsit_find_cmd_from_itt_or_dump(
373373
struct iscsi_conn *conn,
374-
u32 init_task_tag,
374+
itt_t init_task_tag,
375375
u32 length)
376376
{
377377
struct iscsi_cmd *cmd;
@@ -417,7 +417,7 @@ int iscsit_find_cmd_for_recovery(
417417
struct iscsi_session *sess,
418418
struct iscsi_cmd **cmd_ptr,
419419
struct iscsi_conn_recovery **cr_ptr,
420-
u32 init_task_tag)
420+
itt_t init_task_tag)
421421
{
422422
struct iscsi_cmd *cmd = NULL;
423423
struct iscsi_conn_recovery *cr;
@@ -855,7 +855,7 @@ static int iscsit_add_nopin(struct iscsi_conn *conn, int want_response)
855855
cmd->iscsi_opcode = ISCSI_OP_NOOP_IN;
856856
state = (want_response) ? ISTATE_SEND_NOPIN_WANT_RESPONSE :
857857
ISTATE_SEND_NOPIN_NO_RESPONSE;
858-
cmd->init_task_tag = 0xFFFFFFFF;
858+
cmd->init_task_tag = RESERVED_ITT;
859859
spin_lock_bh(&conn->sess->ttt_lock);
860860
cmd->targ_xfer_tag = (want_response) ? conn->sess->targ_xfer_tag++ :
861861
0xFFFFFFFF;
@@ -1222,7 +1222,7 @@ int iscsit_tx_login_rsp(struct iscsi_conn *conn, u8 status_class, u8 status_deta
12221222
hdr->opcode = ISCSI_OP_LOGIN_RSP;
12231223
hdr->status_class = status_class;
12241224
hdr->status_detail = status_detail;
1225-
hdr->itt = cpu_to_be32(conn->login_itt);
1225+
hdr->itt = conn->login_itt;
12261226

12271227
iov.iov_base = &iscsi_hdr;
12281228
iov.iov_len = ISCSI_HDR_LEN;

‎drivers/target/iscsi/iscsi_target_util.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ extern struct iscsi_seq *iscsit_get_seq_holder_for_r2t(struct iscsi_cmd *);
1414
extern struct iscsi_r2t *iscsit_get_holder_for_r2tsn(struct iscsi_cmd *, u32);
1515
int iscsit_sequence_cmd(struct iscsi_conn *conn, struct iscsi_cmd *cmd, u32 cmdsn);
1616
extern int iscsit_check_unsolicited_dataout(struct iscsi_cmd *, unsigned char *);
17-
extern struct iscsi_cmd *iscsit_find_cmd_from_itt(struct iscsi_conn *, u32);
17+
extern struct iscsi_cmd *iscsit_find_cmd_from_itt(struct iscsi_conn *, itt_t);
1818
extern struct iscsi_cmd *iscsit_find_cmd_from_itt_or_dump(struct iscsi_conn *,
19-
u32, u32);
19+
itt_t, u32);
2020
extern struct iscsi_cmd *iscsit_find_cmd_from_ttt(struct iscsi_conn *, u32);
2121
extern int iscsit_find_cmd_for_recovery(struct iscsi_session *, struct iscsi_cmd **,
22-
struct iscsi_conn_recovery **, u32);
22+
struct iscsi_conn_recovery **, itt_t);
2323
extern void iscsit_add_cmd_to_immediate_queue(struct iscsi_cmd *, struct iscsi_conn *, u8);
2424
extern struct iscsi_queue_req *iscsit_get_cmd_from_immediate_queue(struct iscsi_conn *);
2525
extern void iscsit_add_cmd_to_response_queue(struct iscsi_cmd *, struct iscsi_conn *, u8);

0 commit comments

Comments
 (0)