iscsit: add missing endianess conversion in iscsit_check_inaddr_any

Christoph Hellwig · Nicholas Bellinger · commit cea0b4ceec5d · 2012-10-02T14:42:25.000-07:00
Sparse noticed that INADDR_ANY needs to be converted to big endian before
it can be stored in struct sockaddr_in.s_addr.

Signed-off-by: Christoph Hellwig &lt;hch@lst.de&gt;
Signed-off-by: Nicholas Bellinger &lt;nab@linux-iscsi.org&gt;
diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
@@ -3239,7 +3239,7 @@ static bool iscsit_check_inaddr_any(struct iscsi_np *np)
 		struct sockaddr_in * sock_in =
 			(struct sockaddr_in *)&np->np_sockaddr;
 
-		if (sock_in->sin_addr.s_addr == INADDR_ANY)
+		if (sock_in->sin_addr.s_addr == htonl(INADDR_ANY))
 			ret = true;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -3239,7 +3239,7 @@ static bool iscsit_check_inaddr_any(struct iscsi_np *np)`
`3239`	`3239`	`struct sockaddr_in * sock_in =`
`3240`	`3240`	`(struct sockaddr_in *)&np->np_sockaddr;`
`3241`	`3241`
`3242`		`- if (sock_in->sin_addr.s_addr == INADDR_ANY)`
	`3242`	`+ if (sock_in->sin_addr.s_addr == htonl(INADDR_ANY))`
`3243`	`3243`	`ret = true;`
`3244`	`3244`	`}`
`3245`	`3245`