Add LinearMap entry() and retain() #577
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
419d010 to
20b3b69
Compare
sgued
requested changes
Aug 22, 2025
Comment on lines
+686
to
+693
| // SAFETY: `idx` must not be modified after construction, and | ||
| // the size of `map` must not be changed. |
There was a problem hiding this comment.
Suggested change
| // SAFETY: `idx` must not be modified after construction, and | |
| // the size of `map` must not be changed. | |
| // SAFETY: `idx` must point to an existing item of the buffer |
I don't think that there is any safety issue as long as idx < buffer.len(), only potential logic issues.
There was a problem hiding this comment.
It's using get_unchecked() so if self.map.buffer shrank it'd be UB. Maybe I've missed something though?
I wasn't sure whether it was worth using _unchecked() functions, was following the convention of other bits of heapless.
entry tests and docs are copied verbatim from IndexMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made
linear_mappublic as a namespace forlinear_map::Entry. There could be a bit of confusion with thecrate::Entryre-export ofindex_map::Entry, not sure if there's any better option.Closes #471